Update openvm to 1.4.0 #3291
Update openvm to 1.4.0 #3291
Conversation
…f, but can't get column names
[Ovm 1.4] get original airs
[OVM 1.4] `VmConfig` related trait implementations
|
Should we have this merged? |
|
|
||
| [features] | ||
| default = [] | ||
| tco = ["openvm-sdk/tco"] |
| repository.workspace = true | ||
|
|
||
| [features] | ||
| default = [] |
There was a problem hiding this comment.
why is metrics default in cli-openvm but not here?
There was a problem hiding this comment.
the metrics are required for benchmarks to work on ci. Happy to remove the default and pass the feature explicitly there. For here, same, I don't have a strong opinion, but metrics sounds more like something you'd turn on only if needed.
|
|
||
| fn pc_step(&self) -> u32 { | ||
| self.0.step | ||
| DEFAULT_PC_STEP |
There was a problem hiding this comment.
This relies on different behavior as before. Do we not have access to the program's step anymore?
There was a problem hiding this comment.
No, as far as I understand, only the default is supported now.
| &exe.program, | ||
| labels.clone(), | ||
| exe.program.pc_base, | ||
| exe.program.step, |
| new_local_prover(vm_builder, &vm_pk, exe)?; | ||
|
|
||
| vm_instance.reset_state(inputs.clone()); | ||
| let metered_ctx = vm_instance.vm.build_metered_ctx(); |
There was a problem hiding this comment.
Why do we need to do all this new stuff?
There was a problem hiding this comment.
It was inlined from on internal function in ovm to build the proving context without calling the prover, and then run debug_proving_ctx. Agree it could be cleaner.
| air_by_opcode_id.air_name_to_machine.get(air_name).unwrap(); | ||
|
|
||
| // TODO: main_columns might not be correct, as the RA::with_capacity() uses the following `main_width()` | ||
| // pub fn main_width(&self) -> usize { |
4 participants
This PR updated the openvm dependency to 1.4.0. A lot of changes were introduced, hence the size of this PR.
Not covered in this PR:
Changes to openvm here
Changes to stark-backend here
Tasks:
Send + Syncbound on Executor in ovm (instead, removed the need for that bound in ovm)